Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19448#discussion_r144195079
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
 ---
    @@ -138,6 +138,10 @@ class ParquetFileFormat
           conf.setBoolean(ParquetOutputFormat.ENABLE_JOB_SUMMARY, false)
         }
     
    +    require(!conf.getBoolean(ParquetOutputFormat.ENABLE_JOB_SUMMARY, false)
    --- End diff --
    
    In Spark SQL, we do issue the `AnalysisException` in many similar cases. I 
am also fine to use `SparkException`. 
    
    In this specific case, the users are able to control the conf to make it 
works. Thus, we also need to improve the message to let users know how to 
resolve it by changing the conf. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to