Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/19337
For the comments about change the name of epsilon and add setter in
localLADModel, we have agreed not to change it now after some offline
discussion.
Because epsilon doesn't control model convergence directly, and some other
LDA implementations like Vowpal Vabbit also uses this name.
Because there are many parameters in LDA, epsilon is just one of them, now
there is no setter for any of them. If we need to add setter of them, we maybe
add them together in another PR.
Thanks. @hhbyyh @jkbradley
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
