Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19459#discussion_r143906469
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -3095,16 +3095,32 @@ def setUpClass(cls):
                 StructField("3_long_t", LongType(), True),
                 StructField("4_float_t", FloatType(), True),
                 StructField("5_double_t", DoubleType(), True)])
    -        cls.data = [("a", 1, 10, 0.2, 2.0),
    -                    ("b", 2, 20, 0.4, 4.0),
    -                    ("c", 3, 30, 0.8, 6.0)]
    +        cls.data = [(u"a", 1, 10, 0.2, 2.0),
    +                    (u"b", 2, 20, 0.4, 4.0),
    +                    (u"c", 3, 30, 0.8, 6.0)]
    +
    +    @classmethod
    +    def tearDownClass(cls):
    +        ReusedPySparkTestCase.tearDownClass()
    +        cls.spark.stop()
     
         def assertFramesEqual(self, df_with_arrow, df_without):
             msg = ("DataFrame from Arrow is not equal" +
                    ("\n\nWith Arrow:\n%s\n%s" % (df_with_arrow, 
df_with_arrow.dtypes)) +
                    ("\n\nWithout:\n%s\n%s" % (df_without, df_without.dtypes)))
             self.assertTrue(df_without.equals(df_with_arrow), msg=msg)
     
    +    def createPandasDataFrameFromeData(self):
    --- End diff --
    
    nit: typo `createPandasDataFrameFromeData` -> 
`createPandasDataFrameFromData`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to