Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144664962
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -349,12 +356,28 @@ case class StreamingSymmetricHashJoinExec(
/**
* Internal helper class to consume input rows, generate join output
rows using other sides
* buffered state rows, and finally clean up this sides buffered state
rows
+ *
+ * @param joinSide The JoinSide - either left or right.
+ * @param inputAttributes The input attributes for this side of the join.
+ * @param joinKeys The join keys.
+ * @param inputIter The iterator of input rows on this side to be joined.
+ * @param preJoinFilter A filter over rows on this side. This filter
rejects rows that could
+ * never pass the overall join condition no matter
what other side row
+ * they're joined with.
+ * @param postJoinFilter A filter over joined rows. This filter
completes the application of the
+ * overall join condition, assuming that
preJoinFilter on both sides of the
+ * join has already been passed.
--- End diff --
^ awesome docs, very clear.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
