Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19502#discussion_r144752376
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala ---
@@ -255,10 +256,7 @@ private[orc] class OrcOutputWriter(
}
}
-private[orc] object OrcRelation extends HiveInspectors {
- // The references of Hive's classes will be minimized.
- val ORC_COMPRESSION = "orc.compress"
--- End diff --
We have documented `orc.compress` as option explicitly in
https://github.com/apache/spark/blob/d8f45408635d4fccac557cb1e877dfe9267fb326/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala#L523
Now we depends on the configuration name from an external library. But I
think the configuration name should not be changed at all. So looks should be
fine.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
