Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19363#discussion_r144753514
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -46,6 +36,20 @@ abstract class QueryTest extends PlanTest {
Locale.setDefault(Locale.US)
/**
+ * Makes sure the answer matches the expected result
+ */
+ def checkString(expected: String, actual: String): Unit = {
+ if (expected != actual) {
+ fail(
+ "The actual string gives wrong result:\n\n" + sideBySide(
--- End diff --
it's kind of an overkill, the `toString` we are testing always return a
single line, just `assert` is enough.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
