Github user nkronenfeld commented on the issue:
https://github.com/apache/spark/pull/19529
I made my original changes here by using
git mv PlanTest.scala PlanTestBase.scala
git mv SQLTestUnit.scala SQLTestUnitBase.scala
git mv SharedSQLContext.scala SharedSparkSession.scala
and then created new PlanTest, SQLTestUnit, and SharedSQLContext files,
under the assumption that most of the code would go in the base, and this would
help git provide better history and continuity. I'm not sure if that was the
right decision or not - probably it is with PlanTest and SQLTestUnit, possibly
not with SharedSQLContext, but since the diff in the PR doesn't reflect the git
mv properly, I'm not sure if it will make a difference either way.
If reviewers wish me to redo this PR without the initial `git mv`, I'll be
happy to.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
