Github user ambauma commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19528#discussion_r146084730
  
    --- Diff: python/pyspark/mllib/classification.py ---
    @@ -173,7 +173,7 @@ def __init__(self, weights, intercept, numFeatures, 
numClasses):
                 self._dataWithBiasSize = None
                 self._weightsMatrix = None
             else:
    -            self._dataWithBiasSize = self._coeff.size / (self._numClasses 
- 1)
    +            self._dataWithBiasSize = self._coeff.size // (self._numClasses 
- 1)
    --- End diff --
    
    The NewSparkPullRequestBuilder failed on python tests.  I was only able to 
duplicate the failure with Python 3.4 and numpy 1.12.1, which I'm guessing is 
the versions that NewSparkPullRequestBuilder is using.  Older and newer 
versions of numpy build clean either way.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to