Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r146426810
--- Diff: pom.xml ---
@@ -2649,6 +2649,13 @@
</profile>
<profile>
+ <id>kubernetes</id>
+ <modules>
+ <module>resource-managers/kubernetes/core</module>
--- End diff --
Why are integration tests in a separate module? e.g. maven has an
`integration-test` phase which is separate from the usual `test` phase used for
unit tests. And that's assuming that you really don't want to run them during
unit tests. Then all code could potentially live in the same module.
> in the interest of keeping test code together
That would mean keeping the test code in the same module as the core code,
not in a separate module.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
