Github user nkronenfeld commented on the issue:
https://github.com/apache/spark/pull/19529
@gatorsmile sounds good, giving that a try now... assuming tests pass,
I'll check it in and see if it's any better.
I've so far done this for PlanTest and SQLTestUtils
PlanTest I suspect it will make much cleaner.
In SQLTestUtils I suspect it won't help as much, as it was more a
pick-and-choose (this function goes in base, this doesn't)
I haven't done it at all for SharedSQLContext/SharedSparkSession... that
one seems more deserving of a first-level place to me, so I'm more hesitant to,
but if you want, I'll do that one too.
I suspect the correct answer is going to be redoing the PR, with careful
commits that are clearer about what each does... but I'll try this first anyway
:-)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
