Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19589#discussion_r147545171
--- Diff: R/pkg/tests/run-all.R ---
@@ -38,6 +38,10 @@ sparkRFilesBefore <- list.files(path = sparkRDir,
all.files = TRUE)
sparkRTestMaster <- "local[1]"
if (identical(Sys.getenv("NOT_CRAN"), "true")) {
sparkRTestMaster <- ""
+} else {
+ # Disable hsperfdata on CRAN
+ old_java_opt <- Sys.getenv("_JAVA_OPTIONS")
+ Sys.setenv("_JAVA_OPTIONS"=paste("-XX:-UsePerfData", old_java_opt, sep="
"))
--- End diff --
I think perhaps it'd better to set `spark.driver.extraJavaOptions` and
`spark.executor.extraJavaOptions` (use a variable to store its value, as in
`sparkRTestMaster`, or like in vignettes, `sparkSessionConfig`)
btw, I think the convention is camelCase variables :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
