Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19649#discussion_r149003803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -147,7 +154,15 @@ abstract class ExternalCatalog
* Note: If the underlying implementation does not support altering a
certain field,
* this becomes a no-op.
*/
- def alterTable(tableDefinition: CatalogTable): Unit
+ final def alterTable(tableDefinition: CatalogTable): Unit = {
--- End diff --
@cloud-fan , since now we expose `alterTable` interface for other
components to leverage, if we don't track this, then looks like we missed a
piece of `ExternalCatalogEvent`s. I think for now we can add this
`AlterTableEvent`, later on if we removed this method, then we can make this
event a no-op (only kept for compatibility), what do you think?
@wzhfy , I was thinking to add partition related events, but I'm not
clearly sure why this whole piece is missing and is it necessary to add
partition related events? If we have an agreement on such events, I'm OK to add
them.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
