Github user yaooqinn commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19663#discussion_r149561925
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala 
---
    @@ -687,6 +687,20 @@ private[spark] class Client(
       private def createConfArchive(): File = {
         val hadoopConfFiles = new HashMap[String, File]()
     
    +    // SPARK_CONF_DIR shows up in the classpath before 
HADOOP_CONF_DIR/YARN_CONF_DIR
    +    val localConfDir = System.getProperty("SPARK_CONF_DIR",
    +      System.getProperty("SPARK_HOME") + File.separator + "conf")
    +    val dir = new File(localConfDir)
    +    if (dir.isDirectory) {
    +      val files = dir.listFiles(new FileFilter {
    +        override def accept(pathname: File): Boolean = {
    +          pathname.isFile && pathname.getName.endsWith("xml")
    +        }
    +      })
    +      files.foreach { f => hadoopConfFiles(f.getName) = f }
    +    }
    +
    +    // Ensure HADOOP_CONF_DIR/YARN_CONF_DIR not overriding existing files
    --- End diff --
    
    ok, i'd remove it


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to