Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17436#discussion_r151764870
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala
 ---
    @@ -62,7 +69,11 @@ case class InMemoryTableScanExec(
     
       private def createAndDecompressColumn(cachedColumnarBatch: CachedBatch): 
ColumnarBatch = {
         val rowCount = cachedColumnarBatch.numRows
    -    val columnVectors = OnHeapColumnVector.allocateColumns(rowCount, 
columnarBatchSchema)
    +    val columnVectors = if (!conf.offHeapColumnVectorEnabled) {
    --- End diff --
    
    only enable it when `TaskContext.get != null`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to