Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19407#discussion_r151838606
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala 
---
    @@ -267,11 +267,12 @@ final class DataStreamWriter[T] private[sql](ds: 
Dataset[T]) {
             useTempCheckpointLocation = true,
             trigger = trigger)
         } else {
    -      val (useTempCheckpointLocation, recoverFromCheckpointLocation) =
    +      val recoverFromCheckpointLocation = true
    +      val useTempCheckpointLocation =
             if (source == "console") {
    -          (true, true)
    +          true
             } else {
    -          (false, true)
    +          false
    --- End diff --
    
    Do we really need it anymore since the `if` expression is just `source == 
"console"`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to