GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/19780
[SPARK-22551][SQL][WIP] Prevent possible 64kb compile error for common
expression types
## What changes were proposed in this pull request?
For common expression types, such as BinaryExpression and
TernaryExpression, the combination of generated codes of children can possibly
be large. We should put the codes into functions to prevent possible 64kb
compile error.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 SPARK-22551
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19780.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19780
----
commit e08259a41d0f39c751858daba713b30e52a6c3a4
Author: Liang-Chi Hsieh <vii...@gmail.com>
Date: 2017-11-18T15:11:05Z
Put large generated codes of children expressions into functions.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
