Github user Gschiavon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153410217
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/SubmitRestProtocolRequest.scala
---
@@ -46,6 +46,8 @@ private[rest] class CreateSubmissionRequest extends
SubmitRestProtocolRequest {
super.doValidate()
assert(sparkProperties != null, "No Spark properties set!")
assertFieldIsSet(appResource, "appResource")
+ assertFieldIsSet(appArgs, "appArgs")
+ assertFieldIsSet(environmentVariables, "environmentVariables")
--- End diff --
Actually If the caller wouldn't set "appArgs" or "environmentVariables" was
causing a null pointer and leaving the Dispatcher inactive. So now I think the
caller should pass an empty array, I could add a test for that case
@susanxhuynh .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
