Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19845#discussion_r154262931
  
    --- Diff: python/pyspark/ml/tests.py ---
    @@ -1837,6 +1837,29 @@ def test_read_images(self):
             self.assertEqual(ImageSchema.undefinedImageType, "Undefined")
     
     
    +class ImageReaderTest2(PySparkTestCase):
    +
    +    @classmethod
    +    def setUpClass(cls):
    +        PySparkTestCase.setUpClass()
    +        try:
    +            cls.sc._jvm.org.apache.hadoop.hive.conf.HiveConf()
    +        except py4j.protocol.Py4JError:
    +            cls.tearDownClass()
    +            raise unittest.SkipTest("Hive is not available")
    +        except TypeError:
    +            cls.tearDownClass()
    +            raise unittest.SkipTest("Hive is not available")
    +        cls.spark = HiveContext._createForTesting(cls.sc)
    +
    --- End diff --
    
    Add classmethod `tearDownClass` to stop the `cls.spark`? I didn't see 
`HiveContextSQLTests` closes it anyway, maybe we can fix it too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to