GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/19878
[SPARK-22682][SQL] HashExpression does not need to create global variables
## What changes were proposed in this pull request?
It turns out that `HashExpression` can pass around some values via
parameter when splitting codes into methods, to save some global variable slots.
This can also prevent a weird case that global variable appears in
parameter list, which is discovered by
https://github.com/apache/spark/pull/19865
## How was this patch tested?
existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark minor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19878.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19878
----
commit 0e9998e0704b54d8f1352a1936c9b6367ebee15e
Author: Wenchen Fan <wenc...@databricks.com>
Date: 2017-12-04T15:24:46Z
HashExpression does not need to create global variables
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
