Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19783#discussion_r154848018
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/EstimationUtils.scala
 ---
    @@ -114,4 +114,194 @@ object EstimationUtils {
         }
       }
     
    +  /**
    +   * Returns the number of the first bin into which a column values falls 
for a specified
    +   * numeric equi-height histogram.
    +   *
    +   * @param value a literal value of a column
    +   * @param bins an array of bins for a given numeric equi-height histogram
    +   * @return the number of the first bin into which a column values falls.
    +   */
    +  def findFirstBinForValue(value: Double, bins: Array[HistogramBin]): Int 
= {
    +    var binId = 0
    +    bins.foreach { bin =>
    +      if (value > bin.hi) binId += 1
    +    }
    +    binId
    +  }
    +
    +  /**
    +   * Returns the number of the last bin into which a column values falls 
for a specified
    +   * numeric equi-height histogram.
    +   *
    +   * @param value a literal value of a column
    +   * @param bins an array of bins for a given numeric equi-height histogram
    +   * @return the number of the last bin into which a column values falls.
    +   */
    +  def findLastBinForValue(value: Double, bins: Array[HistogramBin]): Int = 
{
    --- End diff --
    
    Why is this method so different from `findFirstBinForValue`? It looks like 
we just need to reverse the iteration order, i.e. from `bins.length` to `0`. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to