Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19874#discussion_r154855820
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
 ---
    @@ -58,7 +58,7 @@ import org.apache.spark.sql.types._
      * - FLOAT and DOUBLE cause fixed-length decimals to turn into DOUBLE
      */
     // scalastyle:on
    -object DecimalPrecision extends Rule[LogicalPlan] {
    +object DecimalPrecision extends Rule[LogicalPlan] with TypePropagation {
    --- End diff --
    
    one benefit of naming it `TypeCoercionRule` is, we can just do `object 
DecimalPrecision extends TypeCoercionRule`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to