Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r154859418
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/rest/mesos/MesosRestServer.scala
---
@@ -77,10 +77,16 @@ private[mesos] class MesosSubmitRequestServlet(
private def buildDriverDescription(request: CreateSubmissionRequest):
MesosDriverDescription = {
// Required fields, including the main class because python is not yet
supported
val appResource = Option(request.appResource).getOrElse {
- throw new SubmitRestMissingFieldException("Application jar is
missing.")
+ throw new SubmitRestMissingFieldException("Application jar
'appResource' is missing.")
}
val mainClass = Option(request.mainClass).getOrElse {
- throw new SubmitRestMissingFieldException("Main class is missing.")
+ throw new SubmitRestMissingFieldException("Main class 'mainClass' is
missing.")
+ }
+ val appArgs = Option(request.appArgs).getOrElse {
+ throw new SubmitRestMissingFieldException("Application arguments
'appArgs' are missing.")
+ }
+ val environmentVariables =
Option(request.environmentVariables).getOrElse {
+ throw new SubmitRestMissingFieldException("Environment variables
'environmentVariables' are missing.")
--- End diff --
so this is API changes - new required arguments for the request.
are folks ok with this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
