Github user danielvdende commented on the issue:
https://github.com/apache/spark/pull/19911
@dongjoon-hyun @gatorsmile As @gatorsmile pointed out, the
`isCascadingTruncateTable` is a method in the public API, so we can't just drop
it. I've made changes again, now the truncate query method is defined for all
dialects by default, with only the PostgresDialect overriding the definition
(for reasons we discussed before). Have also reinstated the test I removed
before (to test the `isCascadingTruncateTable` function). Let me know what you
think, once you're ok with the changes, I'll squash the commits into 1.
Thanks for helping out :), much appreciated.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
