Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19811#discussion_r157408061
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -217,7 +217,7 @@ case class Stack(children: Seq[Expression]) extends
Generator {
ctx.addMutableState(
s"$wrapperClass<InternalRow>",
ev.value,
- s"${ev.value} = $wrapperClass$$.MODULE$$.make($rowData);")
--- End diff --
We can localize the global variable `ev.value` here to save one global
variable slot.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
