Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20020#discussion_r158198250
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -87,6 +87,51 @@ case class ExecutedCommandExec(cmd: RunnableCommand)
extends LeafExecNode {
}
}
--- End diff --
I think the `metrics` in `RunnableCommand` is mainly for use in
`DataWritingCommand`. Now `DataWritingCommand` is a separate class other than
`RunnableCommand`, do we still need `metrics` in `RunnableCommand`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
