Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20068#discussion_r158593580
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala
 ---
    @@ -152,7 +152,7 @@ class CSVOptions(
         
writerSettings.setIgnoreLeadingWhitespaces(ignoreLeadingWhiteSpaceFlagInWrite)
         
writerSettings.setIgnoreTrailingWhitespaces(ignoreTrailingWhiteSpaceFlagInWrite)
         writerSettings.setNullValue(nullValue)
    -    writerSettings.setEmptyValue(nullValue)
    +    writerSettings.setEmptyValue("")
    --- End diff --
    
    Can we simply expose this as an option and keep the previous behaviour if 
this option is not set explicitly by the user?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to