Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20072#discussion_r159175087
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFsRelation.scala
 ---
    @@ -82,7 +82,11 @@ case class HadoopFsRelation(
         }
       }
     
    -  override def sizeInBytes: Long = location.sizeInBytes
    +  override def sizeInBytes: Long = {
    +    val sizeFactor = sqlContext.conf.sizeToMemorySizeFactor
    +    (location.sizeInBytes * sizeFactor).toLong
    --- End diff --
    
    we should add a safe check for overflow.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to