Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20013#discussion_r160580420
--- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
@@ -313,35 +316,68 @@ private class LiveExecutor(val executorId: String,
_addTime: Long) extends LiveE
}
-/** Metrics tracked per stage (both total and per executor). */
-private class MetricsTracker {
- var executorRunTime = 0L
- var executorCpuTime = 0L
- var inputBytes = 0L
- var inputRecords = 0L
- var outputBytes = 0L
- var outputRecords = 0L
- var shuffleReadBytes = 0L
- var shuffleReadRecords = 0L
- var shuffleWriteBytes = 0L
- var shuffleWriteRecords = 0L
- var memoryBytesSpilled = 0L
- var diskBytesSpilled = 0L
-
- def update(delta: v1.TaskMetrics): Unit = {
- executorRunTime += delta.executorRunTime
- executorCpuTime += delta.executorCpuTime
- inputBytes += delta.inputMetrics.bytesRead
- inputRecords += delta.inputMetrics.recordsRead
- outputBytes += delta.outputMetrics.bytesWritten
- outputRecords += delta.outputMetrics.recordsWritten
- shuffleReadBytes += delta.shuffleReadMetrics.localBytesRead +
- delta.shuffleReadMetrics.remoteBytesRead
- shuffleReadRecords += delta.shuffleReadMetrics.recordsRead
- shuffleWriteBytes += delta.shuffleWriteMetrics.bytesWritten
- shuffleWriteRecords += delta.shuffleWriteMetrics.recordsWritten
- memoryBytesSpilled += delta.memoryBytesSpilled
- diskBytesSpilled += delta.diskBytesSpilled
+private class MetricsTracker(
--- End diff --
ok, but the code becomes uglier because `v1.TaskMetrics` is kind of an
annoying type to use.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
