Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20205#discussion_r160581341
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java
---
@@ -196,17 +234,26 @@ public void initBatch(
* by copying from ORC VectorizedRowBatch columns to Spark ColumnarBatch
columns.
*/
private boolean nextBatch() throws IOException {
- for (WritableColumnVector vector : columnVectors) {
- vector.reset();
- }
- columnarBatch.setNumRows(0);
--- End diff --
Yep. I meant keeping here since we return at line 390 and 240.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
