Github user advancedxy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20178#discussion_r160587943
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala ---
    @@ -56,6 +56,8 @@ class StageInfo(
         completionTime = Some(System.currentTimeMillis)
       }
     
    +  def attemptNumber(): Int = attemptId
    --- End diff --
    
    > But let's do it in a new PR, as it may need quite a lot of changes.
    
    Lets's do that after Spark 2.3 release then? 
    
    >However, it's also called attemptId in this class.
    
    Yeah, (stage)attemptId is over a lot of places...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to