Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/20226#discussion_r161147457
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScanExec.scala
---
@@ -62,6 +62,8 @@ case class HiveTableScanExec(
override def conf: SQLConf = sparkSession.sessionState.conf
+ override def nodeName: String = s"${super.nodeName}
(${relation.tableMeta.qualifiedName})"
--- End diff --
@gatorsmile : I have updated the PR after going through all the *ScanExec
implementations
Changes introduced in this PR:
Scan impl | overridden `nodeName`
------------ | -------------
DataSourceV2ScanExec | `Scan DataSourceV2 [output_attribute1,
output_attribute2, ..]`
ExternalRDDScanExec | `Scan ExternalRDD [output_attribute1,
output_attribute2, ..]`
FileSourceScanExec | `Scan FileSource
${tableIdentifier.map(_.unquotedString).getOrElse(relation.location)}"`
HiveTableScanExec | `Scan HiveTable relation.tableMeta.qualifiedName`
InMemoryTableScanExec | `Scan In-memory relation.tableName`
LocalTableScanExec | `Scan LocalTable [output_attribute1,
output_attribute2, ..]`
RDDScanExec | `Scan RDD name [output_attribute1, output_attribute2, ..]`
RowDataSourceScanExec | `Scan FileSource
${tableIdentifier.map(_.unquotedString).getOrElse(relation)}`
Things not affected:
- DataSourceScanExec : already uses `Scan relation
tableIdentifier.unquotedString`
- RDDScanExec forces clients to specify the `nodeName`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
