Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162547306
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -50,7 +50,14 @@ private[sql] trait ColumnarBatchScan extends
CodegenSupport {
dataType: DataType,
nullable: Boolean): ExprCode = {
val javaType = ctx.javaType(dataType)
- val value = ctx.getValue(columnVar, dataType, ordinal)
+ val value = if (dataType.isInstanceOf[StructType]) {
+ // `ColumnVector.getStruct` is different from
`InternalRow.getStruct`, it only takes an
+ // `ordinal` parameter.
+ s"$columnVar.getStruct($ordinal)"
+ } else {
+ ctx.getValue(columnVar, dataType, ordinal)
+ }
--- End diff --
ah I didn't know there is such an API. I'll use it instead.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
