Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20046#discussion_r162759216
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala
 ---
    @@ -86,6 +93,429 @@ class DataFrameWindowFunctionsSuite extends QueryTest 
with SharedSQLContext {
         assert(e.message.contains("requires window to be ordered"))
       }
     
    +  test("aggregation and rows between") {
    +    val df = Seq((1, "1"), (2, "1"), (2, "2"), (1, "1"), (2, 
"2")).toDF("key", "value")
    --- End diff --
    
    We shall also include null data.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to