Github user smurakozi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20330#discussion_r162759866
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
    @@ -427,23 +435,21 @@ private[ui] class JobDataSource(
         val formattedDuration = duration.map(d => 
UIUtils.formatDuration(d)).getOrElse("Unknown")
         val submissionTime = jobData.submissionTime
         val formattedSubmissionTime = 
submissionTime.map(UIUtils.formatDate).getOrElse("Unknown")
    -    val lastStageAttempt = store.lastStageAttempt(jobData.stageIds.max)
    -    val lastStageDescription = lastStageAttempt.description.getOrElse("")
    +    val (lastStageName, lastStageDescription) = 
lastStageNameAndDescription(store, jobData)
     
    -    val formattedJobDescription =
    -      UIUtils.makeDescription(lastStageDescription, basePath, plainText = 
false)
    +    val jobDescription = UIUtils.makeDescription(lastStageDescription, 
basePath, plainText = false)
    --- End diff --
    
    I've moved this logic to `lastStageNameAndDescription`, so it's uniform.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to