Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19054#discussion_r162768714
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
---
@@ -271,23 +325,24 @@ case class EnsureRequirements(conf: SQLConf) extends
Rule[SparkPlan] {
*/
private def reorderJoinPredicates(plan: SparkPlan): SparkPlan = {
plan.transformUp {
- case BroadcastHashJoinExec(leftKeys, rightKeys, joinType, buildSide,
condition, left,
--- End diff --
Removal of `BroadcastHashJoinExec` is intentional. The children are
expected to have `BroadcastDistribution` or `UnspecifiedDistribution` so this
method wont help here (this optimization only helps in case of shuffle based
joins)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
