Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20146#discussion_r162777500
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -249,6 +249,16 @@ object ParamValidators {
def arrayLengthGt[T](lowerBound: Double): Array[T] => Boolean = {
(value: Array[T]) =>
value.length > lowerBound
}
+
+ /** Check if more than one param in a set of exclusive params are set. */
+ def checkExclusiveParams(model: Params, params: String*): Unit = {
+ if (params.filter(paramName => model.hasParam(paramName) &&
--- End diff --
The purpose of this method is to check if more than one Params are set
among some exclusive Params within a Model. Is it useful to put an irrelevant
Param into the exclusive Params to check? As we already know what Params the
model has, it sounds like we want to check an irrelevant Param that we already
know non-existing?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
