Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18277#discussion_r162782791
--- Diff: python/pyspark/rdd.py ---
@@ -751,7 +751,7 @@ def func(iterator):
def pipe_objs(out):
for obj in iterator:
- s = str(obj).rstrip('\n') + '\n'
+ s = unicode(obj).rstrip('\n') + '\n'
--- End diff --
@chaoslawful, if you are active, we could change `\n` to `u\n` to reduce
the conversion and don't rely on the implicit conversion between `str` and
`unicode`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
