Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20204#discussion_r162785336
  
    --- Diff: python/run-tests-with-coverage ---
    @@ -0,0 +1,69 @@
    +#!/usr/bin/env bash
    +
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +set -o pipefail
    +set -e
    +
    +# This variable indicates which coverage executable to run to combine 
coverages
    +# and generate HTMLs, for example, 'coverage3' in Python 3.
    +COV_EXEC="${COV_EXEC:-coverage}"
    +FWDIR="$(cd "`dirname $0`"; pwd)"
    +pushd "$FWDIR" > /dev/null
    +
    +# Ensure that coverage executable is installed.
    +if ! hash $COV_EXEC 2>/dev/null; then
    +  echo "Missing coverage executable in your path, skipping PySpark 
coverage"
    +  exit 1
    +fi
    +
    +# Set up the directories for coverage results.
    +export COVERAGE_DIR="$FWDIR/test_coverage"
    +rm -fr "$COVERAGE_DIR/coverage_data"
    +rm -fr "$COVERAGE_DIR/htmlcov"
    +mkdir -p "$COVERAGE_DIR/coverage_data"
    +
    +# Current directory are added in the python path so that it doesn't refer 
our built
    +# pyspark zip library first.
    +export PYTHONPATH="$FWDIR:$PYTHONPATH"
    +# Also, our sitecustomize.py and coverage_daemon.py are included in the 
path.
    +export PYTHONPATH="$COVERAGE_DIR:$PYTHONPATH"
    +
    +# We use 'spark.python.daemon.module' configuration to insert the coverage 
supported workers.
    +export SPARK_CONF_DIR="$COVERAGE_DIR/conf"
    +
    +# This environment variable enables the coverage.
    +export COVERAGE_PROCESS_START="$FWDIR/.coveragerc"
    +
    +# If you'd like to run a specific unittest class, you could do such as
    +# SPARK_TESTING=1 ../bin/pyspark pyspark.sql.tests VectorizedUDFTests
    +./run-tests "$@"
    --- End diff --
    
    Another tip is, if we use `../bin/pyspark` here, do some simple tests and 
then exit, it looks still producing the coverage correctly.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to