Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20277#discussion_r162860736
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/VectorizedHashMapGenerator.scala
---
@@ -127,8 +127,10 @@ class VectorizedHashMapGenerator(
def genEqualsForKeys(groupingKeys: Seq[Buffer]): String = {
groupingKeys.zipWithIndex.map { case (key: Buffer, ordinal: Int) =>
- s"""(${ctx.genEqual(key.dataType,
ctx.getValue(s"vectors[$ordinal]", "buckets[idx]",
- key.dataType), key.name)})"""
+ // `ColumnVector.getStruct` is different from
`InternalRow.getStruct`, it only takes an
+ // `ordinal` parameter.
+ val value = ctx.getValue(s"vectors[$ordinal]", key.dataType,
"buckets[idx]")
--- End diff --
`getValueFromVector` instead of `getValue`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
