Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20355#discussion_r163152164
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/text/TextSuite.scala
---
@@ -172,6 +172,14 @@ class TextSuite extends QueryTest with
SharedSQLContext {
}
}
+ test("SPARK-23148: test for spaces in file names") {
--- End diff --
Alternatively, adding the test like below in
`FileBasedDataSourceSuite.scala`, instead of `CSVSuite` and `JsonSuite`:
```scala
// Only CSV/JSON supports multiLine option and the code paths are different
blabla ..
Seq("csv", "json").foreach { format =>
test(s"SPARK-23148 read files containing special characters using $format
- multLine enabled") {
val nameWithSpecialChars = s"sp&ci al%chars"
withTempDir { dir =>
... spark.read.option("multuLine", true).format(format)...
}
}
}
```
could be also fine if possible. Either way is fine to me.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
