Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/20368#discussion_r163376001
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala
---
@@ -126,6 +126,22 @@ class BroadcastJoinSuite extends QueryTest with
SQLTestUtils {
}
}
+ test("broadcast hint is retained in a cached plan") {
+ Seq(true, false).foreach { materialized =>
+ withSQLConf(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
+ val df1 = spark.createDataFrame(Seq((1, "4"), (2,
"2"))).toDF("key", "value")
+ val df2 = spark.createDataFrame(Seq((1, "1"), (2,
"2"))).toDF("key", "value")
+ broadcast(df2).cache()
+ if (materialized) df2.collect()
+ val df3 = df1.join(df2, Seq("key"), "inner")
--- End diff --
`val df3 = df1.join(df2, "key")`? `inner` is implied, isn't it? (I'm
proposing the change as this and other tests could be easily used as a learning
tool to master Spark SQL's API)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
