Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20169
Let me explain my point here. I am not trying to offend anybody. Spark is
becoming more and more complex. Peer review and test cases are the major
methods we used for quality control. Spark is an infrastructure software,
instead of an application software. We really need to be careful when reviewing
the PRs. Nobody's codes are perfect. For example, if I made a change in SHS, I
will ping @vanzin for sure, because @vanzin is the original author and the most
active committer of SHS.
Personally, I am doing my best to review the changes in the SQL. It would
be nice if you can ping me or @cloud-fan . Since Spark 2.3 release is the
recent focus, the current focus of the whole community is for testing and
reviewing the changes of Spark 2.3 release.
Regarding this PR, I think we do not need to introduce new parameter
`warehouseDir`, which is already contained in `hadoopConf `. Keeping the
interface clean is always good, I believe. Please review my follow-up PR:
https://github.com/apache/spark/pull/20377
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
