Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20338#discussion_r163465854
  
    --- Diff: dev/tox.ini ---
    @@ -13,7 +13,7 @@
     # See the License for the specific language governing permissions and
     # limitations under the License.
     
    -[pep8]
    -ignore=E402,E731,E241,W503,E226
    +[pycodestyle]
    +ignore=E402,E731,E241,W503,E226,E722,E741,E305
    --- End diff --
    
    should we fix the code that violates
    
    E722: "do not use bare except'"
    E741: "ambiguous variable name 'l'",
    E305: "expected 2 blank lines after class or function definition"
    ?
    
    Or that's another PR/JIRA?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to