Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20369#discussion_r163751348
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/streaming/StreamWriteSupport.java
---
@@ -48,7 +48,7 @@
* @param options the options for the returned data source writer,
which is an immutable
* case-insensitive string-to-string map.
*/
- Optional<ContinuousWriter> createContinuousWriter(
+ Optional<StreamWriter> createStreamWriter(
--- End diff --
do we still need to return `Optional`? In which case an implementation
should return `None`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
