Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20419#discussion_r164951129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -1227,12 +1227,13 @@ class CodegenContext {
/**
* Register a comment and return the corresponding place holder
*/
- def registerComment(text: => String): String = {
+ def registerComment(text: => String, forceComment: Boolean = false):
String = {
--- End diff --
Nit: rename it to `force`?
Also adding the text?
```
@param force whether to force registering the comments
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
