Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20448#discussion_r164953600
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2QueryPlan.scala
---
@@ -19,50 +19,31 @@ package org.apache.spark.sql.execution.datasources.v2
import java.util.Objects
-import org.apache.spark.sql.catalyst.expressions.{Attribute,
AttributeReference}
-import org.apache.spark.sql.sources.v2.reader._
+import org.apache.spark.sql.catalyst.expressions.{Attribute, AttributeSet,
Expression}
+import org.apache.spark.sql.sources.v2.DataSourceV2
/**
- * A base class for data source reader holder with customized
equals/hashCode methods.
+ * A base class for data source v2 related query plan. It defines the
equals/hashCode methods
+ * according to some common information.
--- End diff --
We might need to emphasize this is for both physical and logical plans.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
