Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20400#discussion_r164972094
  
    --- Diff: python/pyspark/sql/window.py ---
    @@ -212,16 +218,20 @@ def rangeBetween(self, start, end):
             values directly.
     
             :param start: boundary start, inclusive.
    -                      The frame is unbounded if this is 
``Window.unboundedPreceding``, or
    +                      The frame is unbounded if this is 
``Window.unboundedPreceding``,
    +                      
``org.apache.spark.sql.catalyst.expressions.UnboundedPreceding``, or
                           any value less than or equal to max(-sys.maxsize, 
-9223372036854775808).
             :param end: boundary end, inclusive.
    -                    The frame is unbounded if this is 
``Window.unboundedFollowing``, or
    +                    The frame is unbounded if this is 
``Window.unboundedFollowing``,
    +                    
``org.apache.spark.sql.catalyst.expressions.UnboundedFollowing``, or
                         any value greater than or equal to min(sys.maxsize, 
9223372036854775807).
    +
    --- End diff --
    
    Can we have a doctest resembling this -
     
https://github.com/jiangxb1987/spark/blob/cec519b8cfbf1ed2a3107056ef5281a5be75ec54/sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala#L214-L240
    ?



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to