GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/20450

    [SPARK-23280][SQL] add map type support to ColumnVector

    ## What changes were proposed in this pull request?
    
    Fill the last missing piece of `ColumnVector`: the map type support.
    
    The idea is similar to the array type support. A map is basically 2 arrays 
for keys and values. We ask the implementations to provide a key array, a value 
array, and an offset and length to specify the range of this map in the 
key/value array.
    
    In `WritableColumnVector`, we put the key array in first child vector, and 
value array in second child vector, and offsets and lengths in the current 
vector, which is very similar to how array type is implemented here.
    
    ## How was this patch tested?
    
    a new test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark map

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20450.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20450
    
----
commit 8e66fb5077c68ff1378ec2a9e4238f9d73af5fb4
Author: Wenchen Fan <wenchen@...>
Date:   2018-01-30T10:52:12Z

    add map type support to ColumnVector

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to