GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/20463
[SQL][MINOR] Inline SpecifiedWindowFrame.defaultWindowFrame().
## What changes were proposed in this pull request?
SpecifiedWindowFrame.defaultWindowFrame(hasOrderSpecification,
acceptWindowFrame) was designed to handle the cases when some Window functions
don't support setting a window frame (e.g. rank). However this param is never
used.
We may inline the whole of this function to simplify the code.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiangxb1987/spark defaultWindowFrame
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20463.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20463
----
commit 895e17c067dffa69ce97368edbf9289239574431
Author: Xingbo Jiang <xingbo.jiang@...>
Date: 2018-01-31T23:02:00Z
inline SpecifiedWindowFrame.defaultWindowFrame().
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
