Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20464#discussion_r165571511 --- Diff: R/pkg/R/column.R --- @@ -169,7 +169,7 @@ setMethod("alias", #' @note substr since 1.4.0 setMethod("substr", signature(x = "Column"), function(x, start, stop) { - jc <- callJMethod(x@jc, "substr", as.integer(start - 1), as.integer(stop - start + 1)) + jc <- callJMethod(x@jc, "substr", as.integer(start), as.integer(stop - start + 1)) --- End diff -- question: - is there a way to make the behavior the same before this change for any caller calling substr with common index like 0 - why consider other changes as a follow up and not here? https://github.com/apache/spark/pull/20464#issuecomment-362162014
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org